fix: Unexpected token QuotedString#65 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofantor
changed the title
|
oh man, this is smart! thanks for the contribution @mofantor can you please make the linter happy so I can merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Analysis:
Comments can appear on any line, including within multi-line directives. The parser must correctly handle inline comments that appear within multi-line configurations.
Fix:
Modified the
InLineCommentstructure and logic to ensure that all functionalities of inline comments are properly handled. Specifically, this includes tracking the line numbers of inline comments so that they can be accurately output during configuration formatting.This fix addresses the issue where the parser was failing to handle quoted strings followed by inline comments in multi-line directives, as described in issue #65.